Skip to content

Allow Symfony 3 components for site-local installs of Drush 8.x#2800

Merged
greg-1-anderson merged 4 commits into
8.xfrom
allow-symfony-3
Oct 6, 2017
Merged

Allow Symfony 3 components for site-local installs of Drush 8.x#2800
greg-1-anderson merged 4 commits into
8.xfrom
allow-symfony-3

Conversation

@greg-1-anderson

Copy link
Copy Markdown
Member

While keeping global installs at Symfony 2.

If we do not allow Symfony 3 components, then site-local installs of Drush 8.x will not work with Drupal 8.4.x. However, if we simply add Symfony 3 to the require section, then we will break global installs of Drush for Drupal 8.3.x. To prevent this, we pin Symfony components to Symfony 2 in require-dev.

c.f. #2799

@greg-1-anderson

greg-1-anderson commented Jun 8, 2017

Copy link
Copy Markdown
Member Author

Drush 8.x will not support site-local installation for Drupal 8.4.x or later. Use Drush 9 for that.

@greg-1-anderson

Copy link
Copy Markdown
Member Author

Let's revisit this for 8.1.15

@greg-1-anderson

Copy link
Copy Markdown
Member Author

Here are the installation permutations with this PR:

  • composer require of Drush8 outside a Drupal site gets Symfony 2. Global Drush 8 w/ Symfony 2 works with Drupal 8.3 and Drupal 8.4.
  • composer require of Drush8 inside a Drupal 8.4 site gets Symfony 3
  • composer require of Drush8 inside a Drupal 8.3 site gets Symfony 2
  • The phar gets Symfony 2, just like the first example

The composer.lock file has Symfony 2.

@grasmash

grasmash commented Oct 6, 2017

Copy link
Copy Markdown
Contributor

composer require of Drush8 inside a Drupal 8.4 site gets Symfony 3

Much needed!

@xjm

xjm commented Oct 14, 2017

Copy link
Copy Markdown

Added a followup for this in core: https://www.drupal.org/node/2916204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants