-
Notifications
You must be signed in to change notification settings - Fork 25.3k
fix: handle null path parameter in RestNodesCapabilitiesAction and pr… #113413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thecoop
merged 5 commits into
elastic:main
from
nbenliogludev:fix/npe-capabilities-null-path
Sep 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9796c99
fix: handle null path parameter in RestNodesCapabilitiesAction and pr…
nbenliogludev 9f7114d
Add changelog for issue 113413
nbenliogludev 1bdf462
fix: use default value '/' for 'path' parameter instead of null check
nbenliogludev 4a06387
docs: update changelog for issue 113413 with valid area
nbenliogludev 4314ae6
Merge branch 'main' into fix/npe-capabilities-null-path
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
fix: handle null path parameter in RestNodesCapabilitiesAction and pr…
…event NPE - Added null check for the 'path' parameter in RestNodesCapabilitiesAction to avoid NullPointerException. - If 'path' is not provided, assign an empty string to ensure safe handling in the URLDecoder and other parts of the code. - Updated the response to return a valid node capabilities result with a successful outcome. - Ensured the request behaves properly when no path is provided, preventing crashes.
- Loading branch information
commit 9796c9944a8f86da3bc07bc163efa50c41652a47
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking for null, we can just use the default value parameter:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thecoop,
I've made the requested change to use request.param("path", "/") as the default value for the path parameter instead of checking for null. Please let me know if there are any further adjustments needed.
Thank you!