Skip to content

ESQL: Limit memory usage of fold #118602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jan 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
8fa64b1
WIP
nik9000 Dec 6, 2024
8ccd678
Merge branch 'main' into fold_ctx_2
nik9000 Dec 10, 2024
a126e84
WIP:
nik9000 Dec 10, 2024
bc661ce
Merge branch 'main' into fold_ctx_2
nik9000 Dec 12, 2024
28ac84f
Fixup
nik9000 Dec 12, 2024
facd394
actual tests
nik9000 Dec 12, 2024
17d2fc4
Update docs/changelog/118602.yaml
nik9000 Dec 12, 2024
faf0e5e
Merge branch 'main' into fold_ctx_2
nik9000 Dec 13, 2024
dd9eeba
Compile again
nik9000 Dec 13, 2024
f46447e
Merge remote-tracking branch 'nik9000/fold_ctx_2' into fold_ctx_2
nik9000 Dec 13, 2024
739e9bf
Merge branch 'main' into fold_ctx_2
nik9000 Dec 27, 2024
6660b88
BigArrays too
nik9000 Dec 27, 2024
b9ea47f
Merge branch 'main' into fold_ctx_2
nik9000 Jan 3, 2025
2e24625
Update x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/…
nik9000 Jan 9, 2025
5a7fe2e
Merge branch 'main' into fold_ctx_2
nik9000 Jan 9, 2025
2d063c8
Merge
nik9000 Jan 9, 2025
115477a
Merge remote-tracking branch 'nik9000/fold_ctx_2' into fold_ctx_2
nik9000 Jan 9, 2025
bfbc7eb
Update foldctx
nik9000 Jan 9, 2025
f3fd791
Review
nik9000 Jan 9, 2025
fa12629
Merge branch 'main' into fold_ctx_2
nik9000 Jan 10, 2025
d790556
Make FoldContext have equality
nik9000 Jan 10, 2025
2abbeef
Helper
nik9000 Jan 10, 2025
39440d8
Catch my bug
nik9000 Jan 10, 2025
0d5afb1
Merge branch 'main' into fold_ctx_2
nik9000 Jan 10, 2025
b20f541
Contextualizification
nik9000 Jan 10, 2025
456833d
5%
nik9000 Jan 13, 2025
573a238
Fix hash
nik9000 Jan 13, 2025
5742c23
Moar tests
nik9000 Jan 13, 2025
b43b8d8
Merge branch 'main' into fold_ctx_2
nik9000 Jan 13, 2025
0651b78
Update heap attack now
nik9000 Jan 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update heap attack now
  • Loading branch information
nik9000 committed Jan 13, 2025
commit 0651b78eac55bb0a5a80f938969e4d6424c75a04
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ private void assertFoldCircuitBreaks(ThrowingRunnable r) throws IOException {
logger.info("expected fold circuit breaking {}", map);
assertMap(
map,
matchesMap().entry("status", 400).entry("error", matchesMap().extraOk().entry("type", "ql_fold_too_much_memory_exception"))
matchesMap().entry("status", 400).entry("error", matchesMap().extraOk().entry("type", "fold_too_much_memory_exception"))
);
}

Expand Down Expand Up @@ -409,7 +409,7 @@ public void testHugeManyRepeat() throws IOException {
* Returns many moderately long strings.
*/
public void testManyRepeatFromRow() throws IOException {
int strings = 600;
int strings = 300;
Response resp = manyRepeat("ROW a = 99", strings);
assertManyStrings(resp, strings);
}
Expand All @@ -418,7 +418,7 @@ public void testManyRepeatFromRow() throws IOException {
* Hits a circuit breaker by building many moderately long strings.
*/
public void testHugeManyRepeatFromRow() throws IOException {
assertFoldCircuitBreaks(() -> manyRepeat("ROW a = 99", 1000));
assertFoldCircuitBreaks(() -> manyRepeat("ROW a = 99", 400));
}

/**
Expand Down