Skip to content

Mark read-only flush and verify #119743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 21, 2025
Merged

Mark read-only flush and verify #119743

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
41d8e3f
POC mark read-only
henningandersen Jan 8, 2025
b15fda5
Update docs/changelog/119743.yaml
henningandersen Jan 8, 2025
f918cc8
Two phase read-only marking.
henningandersen Jan 15, 2025
f1edf02
Merge remote-tracking branch 'origin/main' into poc_mark_read_only
henningandersen Jan 15, 2025
77243a6
Do not mark verified from ILM shrink.
henningandersen Jan 15, 2025
d61e784
[CI] Auto commit changes from spotless
Jan 15, 2025
d700dfe
Ability to readd block for unverified block.
henningandersen Jan 16, 2025
349df99
Merge remote-tracking branch 'origin/main' into poc_mark_read_only
henningandersen Jan 16, 2025
48f19b3
Compile fix
henningandersen Jan 16, 2025
3b80145
Only add verified if not verified (with read-only + write block at th…
henningandersen Jan 16, 2025
a3b99a0
Fix deprecation check.
henningandersen Jan 16, 2025
37f2e17
Merge remote-tracking branch 'origin/main' into poc_mark_read_only
henningandersen Jan 17, 2025
213b584
Rolling upgrade IT
henningandersen Jan 20, 2025
58737e4
Merge remote-tracking branch 'origin/main' into poc_mark_read_only
henningandersen Jan 20, 2025
cbe5483
Spotless
henningandersen Jan 20, 2025
2b2f329
phase2 variable name
henningandersen Jan 20, 2025
80c66f8
Merge remote-tracking branch 'origin/main' into poc_mark_read_only
henningandersen Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only add verified if not verified (with read-only + write block at th… 
…e same time).
  • Loading branch information
@henningandersen
henningandersen committed Jan 16, 2025
commit 3b8014546e48b5a5260665f06c4971e80cf86867
10 changes: 6 additions & 4 deletions server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexStateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,10 +1059,12 @@ private static Tuple<ClusterState, List<AddBlockResult>> finalizeBlock(

if (block.getBlock().contains(ClusterBlockLevel.WRITE) && markVerified) {
final IndexMetadata indexMetadata = metadata.getSafe(index);
final IndexMetadata.Builder updatedMetadata = IndexMetadata.builder(indexMetadata)
.settings(Settings.builder().put(indexMetadata.getSettings()).put(VERIFIED_READ_ONLY_SETTING.getKey(), true))
.settingsVersion(indexMetadata.getSettingsVersion() + 1);
metadata.put(updatedMetadata);
if (VERIFIED_READ_ONLY_SETTING.get(indexMetadata.getSettings()) == false) {
final IndexMetadata.Builder updatedMetadata = IndexMetadata.builder(indexMetadata)
.settings(Settings.builder().put(indexMetadata.getSettings()).put(VERIFIED_READ_ONLY_SETTING.getKey(), true))
.settingsVersion(indexMetadata.getSettingsVersion() + 1);
metadata.put(updatedMetadata);
}
}
} catch (final IndexNotFoundException e) {
logger.debug("index {} has been deleted since blocking it started, ignoring", index);
Expand Down