Skip to content

ESQL Support IN operator for Date nanos #119772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 14, 2025
Merged

ESQL Support IN operator for Date nanos #119772

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7c0fe4b
basic tests and functionality
not-napoleon Jan 6, 2025
5154b79
First pass at mixed mode
not-napoleon Jan 7, 2025
861b123
need more testing, but I think this is the right type check
not-napoleon Jan 7, 2025
63404bf
Update docs/changelog/119772.yaml
not-napoleon Jan 8, 2025
2b217a9
[CI] Auto commit changes from spotless
Jan 8, 2025
ed3aaa0
millis IN nanos
not-napoleon Jan 8, 2025
50b9409
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 8, 2025
85ad66f
remove redundant check
not-napoleon Jan 8, 2025
64e2d35
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 9, 2025
7575e38
ignore order for CSV test
not-napoleon Jan 9, 2025
8a0ef1a
Merge remote-tracking branch 'refs/remotes/not-napoleon/esql-date-nan…
not-napoleon Jan 9, 2025
3c71053
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 9, 2025
a4ecd6f
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 10, 2025
a920d48
fix null handling
not-napoleon Jan 13, 2025
7291a34
remove autoboxing
not-napoleon Jan 13, 2025
b8fee10
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 13, 2025
ba0fd97
Merge branch 'main' into esql-date-nanos-in-operator
not-napoleon Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CI] Auto commit changes from spotless
  • Loading branch information
elasticsearchmachine committed Jan 8, 2025
commit 2b217a96c245d14c9459f07a92aa182741dbf4d0
2 changes: 1 addition & 1 deletion ...c/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/comparison/In.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ protected TypeResolution resolveType() { // TODO: move the foldability check fro
seenDateType = listValue.dataType();
}
if ((listValue.dataType().isDate() && listValue.dataType() != seenDateType)
|| (listValue.dataType().isDate() == false &&areCompatible(dt, listValue.dataType()) == false)) {
|| (listValue.dataType().isDate() == false && areCompatible(dt, listValue.dataType()) == false)) {
return new TypeResolution(
format(
null,
Expand Down