Skip to content

[Deprecation API] Refactor resource deprecation checkers and add new resources. #120505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jan 28, 2025
Merged

[Deprecation API] Refactor resource deprecation checkers and add new resources. #120505

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
d20a918
Introduce ResourceDeprecationChecker to group all index, data stream …
gmarouli Jan 21, 2025
da7a12a
Introduce ResourceDeprecationChecker to group all index, data stream …
gmarouli Jan 21, 2025
87c9cb3
Move index settings also to ResourceDeprecationChecker
gmarouli Jan 21, 2025
83589f4
Merge with main
gmarouli Jan 21, 2025
49999c7
Fix XContent serialisation
gmarouli Jan 21, 2025
41505ec
Introduce ComponentTemplateDeprecationChecks
gmarouli Jan 21, 2025
88271a0
Introduce ComponentTemplateDeprecationChecks
gmarouli Jan 21, 2025
286d543
Rename checkers
gmarouli Jan 21, 2025
0797a23
Add new checkers
gmarouli Jan 21, 2025
4457d09
[CI] Auto commit changes from spotless
Jan 21, 2025
bb75c00
Merge with main
gmarouli Jan 22, 2025
6bda1dc
Update tests
gmarouli Jan 22, 2025
5eeec51
Unify component and index templates, remove legacy template check
gmarouli Jan 22, 2025
6df4812
Update tests
gmarouli Jan 23, 2025
9f0b516
Merge with main
gmarouli Jan 23, 2025
48fee10
Change the way we ensure the required fields exist in the response
gmarouli Jan 23, 2025
f2e2782
Remove skipped settings from templates
gmarouli Jan 23, 2025
c0f37b6
Fix test
gmarouli Jan 23, 2025
6e079d2
Extend the yaml tests to include the new resources in deprecation API
gmarouli Jan 23, 2025
349f831
Polishing
gmarouli Jan 23, 2025
733479b
Merge with main
gmarouli Jan 23, 2025
29e3693
Fix test
gmarouli Jan 23, 2025
1098a27
Update docs/changelog/120505.yaml
gmarouli Jan 23, 2025
dbb0c1e
Merge branch 'main' into handle-9/deprecate-node-attrs-v2
gmarouli Jan 23, 2025
2c5da01
Merge with main
gmarouli Jan 24, 2025
dc6ed49
Process review comments
gmarouli Jan 24, 2025
cb7b097
Add missing check
gmarouli Jan 24, 2025
facf5e1
Add new ILM template check for freeze action
gmarouli Jan 24, 2025
5284a61
Merge branch 'main' into handle-9/deprecate-node-attrs-v2
gmarouli Jan 24, 2025
d5f9d8b
Merge branch 'main' into handle-9/deprecate-node-attrs-v2
gmarouli Jan 27, 2025
d557621
Adjust SourceModeRollingUpgradeIT to take into consideration the new …
gmarouli Jan 27, 2025
4ea9f78
Merge branch 'main' into handle-9/deprecate-node-attrs-v2
gmarouli Jan 27, 2025
1b8c69d
Fix test
gmarouli Jan 27, 2025
b898b33
Merge branch 'main' into handle-9/deprecate-node-attrs-v2
gmarouli Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@gmarouli
gmarouli committed Jan 23, 2025
commit c0f37b666929055caa751a5ababfdff7e39d08dd
4 changes: 2 additions & 2 deletions ...b/src/javaRestTest/java/org/elasticsearch/xpack/logsdb/LogsIndexModeCustomSettingsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public void testConfigureStoredSourceBeforeIndexCreation() throws IOException {
assertThat(sourceMode, equalTo("stored"));

request = new Request("GET", "/_migration/deprecations");
var componentTemplates = (Map<?, ?>) entityAsMap(client.performRequest(request)).get("component_templates");
var componentTemplates = (Map<?, ?>) entityAsMap(client.performRequest(request)).get("templates");
assertThat(componentTemplates.containsKey("logs@custom"), equalTo(true));
var issue = ((List<Map<?, ?>>) componentTemplates.get("logs@custom")).getFirst();
assertThat(issue.get("message"), equalTo(SourceFieldMapper.DEPRECATION_WARNING));
Expand Down Expand Up @@ -205,7 +205,7 @@ public void testConfigureStoredSourceWhenIndexIsCreated() throws IOException {
assertThat(sourceMode, equalTo("stored"));

request = new Request("GET", "/_migration/deprecations");
var componentTemplates = (Map<?, ?>) entityAsMap(client.performRequest(request)).get("component_templates");
var componentTemplates = (Map<?, ?>) entityAsMap(client.performRequest(request)).get("templates");
assertThat(componentTemplates.containsKey("logs@custom"), equalTo(true));
var issue = ((List<Map<?, ?>>) componentTemplates.get("logs@custom")).getFirst();
assertThat(issue.get("message"), equalTo(SourceFieldMapper.DEPRECATION_WARNING));
Expand Down