Skip to content

ES|QL - Add scoring for full text functions disjunctions #121793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Mar 11, 2025
Merged

ES|QL - Add scoring for full text functions disjunctions #121793

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
978770d
LuceneQueryScoreEvaluator first implementation
carlosdelest Feb 5, 2025
cb2c3c4
Add ScoreOperator and ScoreMapper
carlosdelest Feb 5, 2025
9ca756a
Add a ExpressionScoreMapper and a ScoreMapper interface to retrieve s…
carlosdelest Feb 5, 2025
e4eb86d
Implement ExpressionScoreMapper for FullTextFunction and BinaryLogic
carlosdelest Feb 5, 2025
a437da3
Create a ScoreOperator that can be planned via the LocalExecutionPlan…
carlosdelest Feb 5, 2025
aa4ffbf
Fix EvalMapper
carlosdelest Feb 5, 2025
1044bfd
Add tests
carlosdelest Feb 5, 2025
5abed67
Spotless
carlosdelest Feb 5, 2025
8b7fd0a
Update docs/changelog/121793.yaml
carlosdelest Feb 5, 2025
72bbd5f
Fix tests
carlosdelest Feb 5, 2025
1bfa58f
Merge remote-tracking branch 'origin/main' into enhancement/esql-scor…
carlosdelest Mar 3, 2025
5cb0bfc
Add testing and capabilities
carlosdelest Mar 4, 2025
3cab2dc
Remove disjunction limitations from docs
carlosdelest Mar 4, 2025
c639ec6
Calculate the _score attr position instead of hardcoding it
carlosdelest Mar 4, 2025
3f3b5b7
Refactor LuceneQueryExpressionEvaluator into a superclass and subclas…
carlosdelest Mar 5, 2025
145955c
Fix tests
carlosdelest Mar 5, 2025
63ca98b
Refactor query evaluators to use subclasses instead of interfaces
carlosdelest Mar 5, 2025
0008559
Merge remote-tracking branch 'carlosdelest/enhancement/esql-score-dis…
carlosdelest Mar 5, 2025
ef3decc
[CI] Auto commit changes from spotless
Mar 5, 2025
6755ab2
Refactor tests
carlosdelest Mar 6, 2025
b2de161
Refactor tests
carlosdelest Mar 6, 2025
bd88335
Refactor tests
carlosdelest Mar 6, 2025
ab8bcf1
Spotless
carlosdelest Mar 6, 2025
0fb9dc7
Merge remote-tracking branch 'origin/main' into enhancement/esql-scor…
carlosdelest Mar 6, 2025
3b994f6
Merge remote-tracking branch 'carlosdelest/enhancement/esql-score-dis…
carlosdelest Mar 6, 2025
9f39ad3
Add javadoc
carlosdelest Mar 6, 2025
0de1df5
Added missing tests
carlosdelest Mar 6, 2025
33016a9
Merge remote-tracking branch 'origin/main' into enhancement/esql-scor…
carlosdelest Mar 6, 2025
c355bcc
Fix changelog
carlosdelest Mar 6, 2025
7457544
Fix test
carlosdelest Mar 10, 2025
e4758d3
Remove unnecessary method
carlosdelest Mar 10, 2025
e3e068c
Add missing capabilities to tests
carlosdelest Mar 10, 2025
5859c81
Merge remote-tracking branch 'origin/main' into enhancement/esql-scor…
carlosdelest Mar 10, 2025
0447824
Merge remote-tracking branch 'origin/main' into enhancement/esql-scor…
carlosdelest Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing capabilities to tests
  • Loading branch information
@carlosdelest
carlosdelest committed Mar 10, 2025
commit e3e068c7e4415121067f08f3ad265f64da5adabc
4 changes: 4 additions & 0 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/scoring.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ book_no:keyword | _score:double
conjunctionScoresPushableNonPushableFunctions

required_capability: metadata_score
required_capability: match_function

from books metadata _score
| where match(title, "Lord") and length(title) > 20
Expand All @@ -411,6 +412,7 @@ book_no:keyword | _score:double
conjunctionScoresPushableFunctions

required_capability: metadata_score
required_capability: match_function

from books metadata _score
| where match(title, "Lord") and ratings > 4.6
Expand All @@ -426,6 +428,7 @@ book_no:keyword | _score:double
disjunctionScoresPushableNonPushableFunctions

required_capability: metadata_score
required_capability: match_operator_colon
required_capability: full_text_functions_disjunctions_score

from books metadata _score
Expand All @@ -447,6 +450,7 @@ book_no:keyword | _score:double
disjunctionScoresMultipleClauses

required_capability: metadata_score
required_capability: match_operator_colon
required_capability: full_text_functions_disjunctions_score

from books metadata _score
Expand Down