Skip to content

[9.0] Improve size limiting string message (#122427) #122534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Feb 13, 2025

Backports the following commits to 9.0:

SizeLimitingStringWriter is used to limit the output size of mustache
scripts. When the size is limited, the resulting exception lacks detail
needed to identify the problem. In particular, the actual size that
would result is not given. Additionally, the excerpt lacks any of the
new string being added. This commit tweaks the exception to include both
of these details.
@rjernst rjernst requested a review from a team as a code owner February 13, 2025 19:29
@rjernst rjernst added :Core/Infra/Core Core issues without another label >enhancement auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team labels Feb 13, 2025
@elasticsearchmachine elasticsearchmachine merged commit 3681c8e into elastic:9.0 Feb 13, 2025
16 checks passed
@rjernst rjernst deleted the backport/9.0/pr-122427 branch February 13, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team v9.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants