Skip to content

Reword lookup join error messages #129312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 16, 2025
Merged

Reword lookup join error messages #129312

merged 10 commits into from
Jun 16, 2025

Conversation

idegtiarenko
Copy link
Contributor

This rewords lookup join messages in order to make them a bit easier to understand.

Related to #120189

@idegtiarenko idegtiarenko added >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.1.0 labels Jun 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

luigidellaquila
luigidellaquila approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

alex-spies
alex-spies requested changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished reviewing, yet, but I don't think we're handling the capability correctly - this disables all bwc tests for LOOKUP JOIN.

Also, I think this should also be backported to 8.19.

alex-spies
alex-spies reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, done now. Marked the tests where we actually need to fiddle around with the capability.

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/join/LookupJoin.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new error messages are much nicer.

@idegtiarenko idegtiarenko requested a review from alex-spies June 13, 2025 07:04
alex-spies
alex-spies approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more contained now and bwc tests are still running against older versions. Thank you!

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/190_lookup_join.yml
@@ -145,15 +145,15 @@ basic:
- match: {values.1: [2, "yellow"]}

---
non-lookup index:
fails with non-lookup index:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bikeshed: I'd prefer something like non-lookup index v2 + a comment why this was bumped.

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/192_lookup_join_on_aliases.yml
@@ -186,15 +186,15 @@ alias-repeated-index:
- match: {values.1: [2, "yellow"]}

---
alias-pattern-multiple:
fails when alias or pattern resolves to multiple:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think that this and the other yaml tests will still fail bwc tests without adding a new cap. But let's see what CI has to say about this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will pass since we renamed the test and skip old one (from versions where the message was different).
As far as I understand this should work the same with backport too.

The build seems to be okay, lets ran it one more time just in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, you are right, this is still failing with serverless

@idegtiarenko idegtiarenko added auto-backport Automatically create backport pull requests when merged v8.19.0 labels Jun 13, 2025
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jun 13, 2025
@idegtiarenko idegtiarenko removed the serverless-linked Added by automation, don't add manually label Jun 16, 2025
@idegtiarenko idegtiarenko merged commit 85e3fb7 into elastic:main Jun 16, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the reword_lookup_join_error_message branch June 16, 2025 13:34
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129312

@idegtiarenko idegtiarenko mentioned this pull request Jun 16, 2025
Merged
idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Jun 16, 2025
@idegtiarenko
Reword lookup join error messages (elastic#129312)
5ca67be 
(cherry picked from commit 85e3fb7)
idegtiarenko added a commit that referenced this pull request Jun 16, 2025
@idegtiarenko
Reword lookup join error messages (#129312) (#129484)
1251218 
(cherry picked from commit 85e3fb7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

@alex-spies alex-spies alex-spies approved these changes

@tylerperk tylerperk Awaiting requested review from tylerperk

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idegtiarenko @elasticsearchmachine @luigidellaquila @alex-spies