Skip to content

Conversation

@chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Nov 6, 2024

Proposed commit message

[checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots

Don't use the EU server as a default for base_url.

Update the Add Integration screenshot and move it after the dashboard
screenshot.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout added bugfix Pull request that fixes a bug issue Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint labels Nov 6, 2024
@chrisberkhout chrisberkhout self-assigned this Nov 6, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner November 6, 2024 15:03
@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Nov 6, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small typo in the PR link.

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2024

🚀 Benchmarks report

Package checkpoint_harmony_endpoint 👍(3) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
antibot 2777.78 1636.66 -1141.12 (-41.08%) 💔
zerophishing 5917.16 4166.67 -1750.49 (-29.58%) 💔

To see the full report comment with /test benchmark fullreport

@chrisberkhout chrisberkhout changed the title [checkpoint_harmony_endpoint] Dashboard screenshot first [checkpoint_harmony_endpoint] Tidy the Server URL var, screenshots Nov 6, 2024
@chrisberkhout
Copy link
Contributor Author

@chemamartinez Sorry, one more change in here. The default Server URL was the EU server. I removed the default and put examples for US and EU in the description.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-sonarqube
Copy link

@chrisberkhout chrisberkhout merged commit 9d7db86 into elastic:main Nov 11, 2024
3 checks passed
@elastic-vault-github-plugin-prod

Package checkpoint_harmony_endpoint - 0.1.1 containing this change is available at https://epr.elastic.co/package/checkpoint_harmony_endpoint/0.1.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…lastic#11652)

Don't use the EU server as a default for base_url.

Update the Add Integration screenshot and move it after the dashboard
screenshot.

---------

Co-authored-by: Chema Martínez <[email protected]>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…lastic#11652)

Don't use the EU server as a default for base_url.

Update the Add Integration screenshot and move it after the dashboard
screenshot.

---------

Co-authored-by: Chema Martínez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:checkpoint_harmony_endpoint Check Point Harmony Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants