test: add defguard macro coverage to jump-to-definition #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend tests to cover jumping to the definition of defguard macros. This ensures guard macros are correctly resolved by code intelligence features, improving reliability for users navigating guard definitions.
There was a problem hiding this comment.
Pull request overview
This PR extends test coverage for the jump-to-definition feature to include defguard macros. It ensures that code intelligence can correctly resolve guard definitions across different usage patterns: remote qualified calls (via require), remote imported calls (via import), and local module calls.
- Added
defguard is_adult(age)to test fixtureMyDefinitionmodule - Added three test cases covering guard definition resolution in different contexts
- Tests verify that clicking on guard usage correctly jumps to the
defguarddefinition
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/forge/test/fixtures/navigations/lib/my_definition.ex | Adds defguard is_adult(age) when age >= 18 fixture for testing guard definition resolution |
| apps/expert/test/engine/code_intelligence/definition_test.exs | Adds three test cases for guard definition lookup: remote qualified call (require), remote imported call (import), and local call patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend tests to cover jumping to the definition of
defguardmacros. This ensures guard macros are correctly resolved by code intelligence features.Demo:
Bandicam_20251123_074441.mp4