fix(wsconn): update cowboy to 2.13.0-emqx-2
#15416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That includes fixes for "crash-on-shutdown" bug in `cowboy_websocket_linger` logic.
ieQu1
approved these changes
Jun 23, 2025
id
approved these changes
Jun 23, 2025
thalesmg
approved these changes
Jun 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-510 #15416 +/- ##
===============================================
+ Coverage 81.63% 81.77% +0.14%
===============================================
Files 1117 1117
Lines 81559 81559
===============================================
+ Hits 66579 66695 +116
+ Misses 14980 14864 -116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-14429.
Release version: 5.10.1?
Summary
emqx/cowboy#13 includes fixes for "crash-on-shutdown" bug in
cowboy_websocket_lingerlogic.PR Checklist
For internal contributor: there is a jira ticket to track this change
The changes are covered with new or existing tests
No new testcases: existing tests (namely,
emqx_persistent_session_SUITE.persistence_disabled.wstest group) are now free of crash reports and "unknown message" warnings.Change log for changes visible by users has been added to
changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesSchema changes are backward compatible