Skip to content

Conversation

@savonarola
Copy link
Contributor

@savonarola savonarola commented Aug 18, 2025

Fixes EMQX-14603

Release version: 6.0.0

Summary

PR Checklist

  • For internal contributor: there is a jira ticket to track this change
  • The changes are covered with new or existing tests
  • Change log for changes visible by users has been added to changes/ee/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • Schema changes are backward compatible or intentionally breaking (describe the changes and the reasoning in the summary)

@savonarola savonarola force-pushed the 250918-fix-gemini branch 2 times, most recently from a127e63 to 6a29786 Compare August 18, 2025 13:29
@savonarola savonarola marked this pull request as ready for review August 18, 2025 13:32
@savonarola savonarola requested a review from a team as a code owner August 18, 2025 13:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.51%. Comparing base (3db32c2) to head (d9d57bb).
⚠️ Report is 5 commits behind head on release-60.

Files with missing lines Patch % Lines
...completions/emqx_ai_completion_openai_response.erl 72.72% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release-60   #15724      +/-   ##
==============================================
+ Coverage       84.48%   84.51%   +0.03%     
==============================================
  Files            1135     1136       +1     
  Lines           79189    79209      +20     
==============================================
+ Hits            66901    66943      +42     
+ Misses          12288    12266      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@savonarola savonarola changed the title feat(ai_completion): support both /response and /chat_completion OpenAI endpoints feat(ai_completion): support both /response and /chat/completion OpenAI endpoints Aug 19, 2025
@savonarola savonarola merged commit 3988a6a into emqx:release-60 Aug 19, 2025
295 of 296 checks passed
@savonarola savonarola deleted the 250918-fix-gemini branch August 19, 2025 09:21
@emqxqa
Copy link

emqxqa commented Aug 19, 2025

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants