Skip to content

feat(pretty_progress_logger): uses commas to delimit large numbers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nh13 merged 1 commit into from
Aug 8, 2022
Merged

feat(pretty_progress_logger): uses commas to delimit large numbers #12

nh13 merged 1 commit into from
Aug 8, 2022

Conversation

@sstadick
Copy link
Contributor

@sstadick sstadick commented Aug 8, 2022

Uses commas to delimit large numbers:

[2022-08-08T01:24:17Z INFO  fqgrep] Creating reader threads
[2022-08-08T01:24:17Z INFO  fqgrep] Processing reads
[2022-08-08T01:24:47Z INFO  proglog] [fqgrep-progress] Searched 50,000,000 reads

nh13
nh13 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank-you!

@nh13 nh13 merged commit 1f1a57a into main Aug 8, 2022
@nh13 nh13 deleted the feature/pretty_progress_logger branch August 8, 2022 01:35
@nh13 nh13 mentioned this pull request Nov 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh13 nh13 nh13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sstadick @nh13