Repository navigation
feat(arguments): add align-rows, subtitle and highlight - #384
Merged
Merged
Conversation
Add the global align-rows, subtitle and highlight arguments and the subtitle and highlight members of the elements type, so downstream card groups can validate them. Mirror the types in the exampleSite shadow copy and add test-cards golden cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
markdumay
enabled auto-merge
October 23, 2026 12:14
Collaborator
Author
|
🎉 This PR is included in version 6.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds global argument definitions for card row alignment:
align-rows(bool, optional, defaultfalse): aligns card parts across each visual row of a card group.subtitleandhighlight(string, optional): a short line below the card title, and an emphasised line between the subtitle and the card body (such as a price).subtitleandhighlightas members of theelementstype, so the mod-blockscardsblock can validate them.These definitions come first in a release chain: hinode, then mod-blocks, then mod-docs.
Tests
The golden bookshop tests gain two cases with a new
test-cardsfixture: a valid aligned block (err: false,alignRows: true) and a misspelt element key (highligt, rejected). Only those two golden entries change.Closes gethinode/hinode#2249
🤖 Generated with Claude Code