vulkan: Fix GGML_VULKAN_CHECK_RESULTS to better handle fusion #16919
+314
−322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can append |
|
Very cool feature, thank you. It's also in the UI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle fusions that have a single output. If there's more than one output (like some of the topk stuff) then the one in the middle won't currently be checked. It should be possible to handle that as well by allocating and comparing multiple results, but I didn't do that yet.
I added a couple missing ops that I hit running test-backend-ops.
Indentation makes this diff look bigger than it really is, I'd suggest reviewing it in a better diff tool.