-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Add e2e tests for embedding raw flag #16940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
015351e to
075c324
Compare
075c324 to
c1c3d99
Compare
|
While testing is great I have issues with this PR:
To sum up; overall as a CI job this will not run when it matters, and when it is run it will not catch any problems of consequence. Lastly, why create a new PR instead of arguing your case in the original PR and maybe iron out concerns there? |
I kept them in
That PR was closed with minimal comment. There appeared to be no room for discussion. |
e5a5b26 to
82dbeee
Compare
82dbeee to
2de1e68
Compare
|
Note: Empty force-pushes are to re-trigger the CI workflow following an intermittent failure. |
6a65869 to
5ce810e
Compare
|
Putting this in draft while work on the RFC continues. |
🧩 Summary
This PR adds a CI workflow for end-to-end embedding CLI tests (none exist today). It establishes a small, fast, reproducible baseline for validating embedding behavior (dimensions + determinism) using tiny GGUF models.
Discussion / design context: See the companion RFC in Discussions for the longer-term plan to add a native server endpoint: #16957
⚙️ What this PR includes