-
Notifications
You must be signed in to change notification settings - Fork 445
feat(gnoweb): In gnoweb help, add QR code for the tx link #4602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes related to gnoweb must be reviewed by its codeowners Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
|
super nice, cc @alexiscolin |
90da275 to
294b30c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Jeff Thompson <[email protected]>
1d2f7b1 to
1e6b810
Compare
The gnoweb help screen already has a tx link for the realm function. We add a popup QR code with the same link.
registerHelpFuncs, addbuildHelpQRwhich returns a base64 of the QR codemake tidy. (This affects go.mod in other folders like gnobro.)This is a draft proof of concept. We still need: