Skip to content

Conversation

@MikaelVallenet
Copy link
Member

@MikaelVallenet MikaelVallenet commented Dec 29, 2025

This PR fixes broken and outdated links throughout the codebase:

  • Fix typo in CONTRIBUTING.md: Missing closing parenthesis in Awesome Gno link
  • Update Makefile commands in READMEs: install_gnokey → install.gnokey, install_gno → install.gno
  • Fix tx-archive path: Updated to gnolang/gno/tree/master/contribs/tx-archive
  • Fix Tendermint links: Updated tendermint/classic references to tendermint/tendermint throughout tm2/
  • Update documentation URLs: Migrated from deprecated tendermint.com/docs/ to docs.tendermint.com/ and docs.cometbft.com/
  • Fix GitHub path formats: Corrected malformed paths like gnolang/gno/tm2/pkg/bft/ to proper gnolang/gno/tree/master/tm2/pkg/bft/ format
  • Fix external references: Updated cosmos-sdk, iavl, and tmlibs links to correct repositories
  • Remove dead references: Removed broken links to non-existent files (e.g., zrealm_nft3.gno, outdated ABCI docs)

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related amino Issues and PRs related to amino 🐳 devops 📄 top-level-md labels Dec 29, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 29, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 29, 2025

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: MikaelVallenet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            └── 🔴 On no pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@Davphla Davphla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re verified all the links and they all working great. I didn't re verify if there's missing broken links.

@Davphla Davphla moved this from NEED PEER REVIEW (INTERNAL) to Waiting for core Review in FlashorgSprint: Gnocore Minicrew 🥷 Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amino Issues and PRs related to amino 🐳 devops 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related review/triage-pending PRs opened by external contributors that are waiting for the 1st review 📄 top-level-md

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants