Add exceptions for breakage introduced in RD barriers#79911
Merged
Conversation
28c7371 to
73b3d37
Compare
Contributor
Author
|
Just waiting on CI to finish so we know the breakage exceptions I need to add... |
dd72026 to
98bcb64
Compare
clayjohn
approved these changes
Jul 26, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks good to me. This should minimize compat breakage if anyone is relying on these barriers and it gets rid of our annoying errors
dsnopek
approved these changes
Jul 26, 2023
dsnopek
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me as well! Thanks!
raulsntos
reviewed
Jul 26, 2023
raulsntos
left a comment
Member
There was a problem hiding this comment.
I don't really know what these barrier flags are, so I added some comments only regarding compatibility.
It does look like it will break compat less and that looks like a good thing.
98bcb64 to
10f796d
Compare
raulsntos
approved these changes
Jul 28, 2023
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor changes to #77420 to:
BARRIER_MASK_COMPUTEandBARRIER_MASK_TRANSFERkeep their original valuesBARRIER_MASK_ALL_BARRIERSandBARRIER_MASK_NO_BARRIERare more future proof in case we add additional flags in the future.Added exceptions to 4.0-stable-expected where applicable.