Skip to content

[TextServer] Store extra spacing of individual font variations.#80954

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:sp_per_font
Aug 28, 2023
Merged

[TextServer] Store extra spacing of individual font variations.#80954
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:sp_per_font

Conversation

@bruvzg

@bruvzg bruvzg commented Aug 24, 2023

Copy link
Copy Markdown
Member

Fixes #80907

Screenshot 2023-08-24 at 11 50 27

@bruvzg bruvzg added this to the 4.2 milestone Aug 24, 2023
@bruvzg bruvzg marked this pull request as ready for review August 26, 2023 19:41
@bruvzg bruvzg requested review from a team as code owners August 26, 2023 19:41

@akien-mga akien-mga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wish we already had structs support for passing this kind of data instead of relying on 4 optional int arguments.

@akien-mga akien-mga merged commit ba10896 into godotengine:master Aug 28, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@akien-mga akien-mga changed the title [Text Server] Store extra spacing of individual font variations. [TextServer] Store extra spacing of individual font variations. Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra Spacing in a nested FontVariation does not work

2 participants