Add some options to Project Settings to silence warnings in AnimationMixer caching#86608
Merged
Merged
Conversation
c95f058 to
05a9f54
Compare
05a9f54 to
e9aa879
Compare
e9aa879 to
6936732
Compare
KoBeWi
reviewed
Feb 11, 2024
Member
KoBeWi
reviewed
Feb 11, 2024
6936732 to
07b7a14
Compare
Member
Author
@KoBeWi Can you send an MRP? I assume the error is the problem somewhere else where the setting not affected (maybe AnimationTrackEditor?). |
599f52c to
bb3b178
Compare
Member
|
Spam is probably exaggerated, there is just a single error print when clicking the AnimationPlayer. |
bb3b178 to
1b7ef45
Compare
Member
Author
|
@KoBeWi The null checks in AnimationTrackEditor were missing in some places, so I fixed them. Errors have gone. The KeyType determination in ValueTrack fails when the node cannot be found with path, but I assume it seems to be expected behavior. |
KoBeWi
reviewed
Feb 12, 2024
1b7ef45 to
a1107f2
Compare
2c63ec6 to
56ecd6b
Compare
Member
Author
|
Oops, sorry I accidentally closed it while cleaning up an old branch. |
56ecd6b to
dc4b7bc
Compare
Member
Author
|
Changed some lines to adopt #88247. |
KoBeWi
approved these changes
Feb 15, 2024
fire
approved these changes
Feb 16, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR is a salvaged version of #69480 with corrected error handling for finding path as pointed out in #85368. Also, as discussed several times in the past, invalid paths will be changed to a warning instead of an error since it is not a critical.
However, since cases where animations do not play due to path mismatches may occur to a certain extent in beginners, so the default is true; There are cases where the destination of add_child scenes is wrong, the name of the Skeleton is changed due to the use of retargeting and etc. It means, flag have been inverted from the original PR (#69480).
And finally, I added a statement in the warning that it is possible to turn off that warning in project settings.
throw_error_with_invalid_pathto Project Setting and remove cache error fromAnimationTree#69480