Update recaptcha-v2-checkbox.php #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking isset on $_POST['g-recaptcha-response'] always passed for me locally on PHP 8.0.14. Changing to !empty actually failed when recaptcha was unchecked, which is the expected behavior.
Contributor
|
I've upgraded everything to work on PHP8+ and do not see this behaviour. Can you verify it's still an issue for you? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking
isseton $_POST['g-recaptcha-response'] always passed for me locally on PHP 8.0.14. Changing to!emptyactually failed when recaptcha was unchecked, which is the expected behavior. Don't know if this works for everyone across the board.