docs(samples): Include clustering fields and schema in CreateClusteredTable as part of the function arguments #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=========================================
Coverage 77.88% 77.88%
Complexity 1184 1184
=========================================
Files 77 77
Lines 6218 6218
Branches 691 691
=========================================
Hits 4843 4843
Misses 1021 1021
Partials 354 354 Continue to review full report at Codecov.
|
955cd8e to
c2b9f55
Compare
6a8b839 to
7e39ca5
Compare
…rguments As of the current version we can see that the schema and clustering fields is already defined in the functions, however by passing it as the arguments engineer can easily change the schema and clustering fields in the IT test thus enable them to understand more about the concept.
7e39ca5 to
cf3769b
Compare
stephaniewang526
approved these changes
May 26, 2020
Contributor
|
Thanks for the improvement. Please commit and name your PR |
Contributor
Author
|
Sure thanks @stephaniewang526 |
This was referenced May 26, 2020
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 26, 2020
…d into method arguments (#386) As the previous PR #382 and #379. I find several other samples that have the tendencies of including tightly coupled variable for each of specific method. Hence I think it will be better to pass it as an argument instead of simply using local variable inside of the method. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #387 ☕️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the current version we can see that the schema and clustering fields
is already defined in the functions, however by passing it as the arguments
engineer can easily change the schema and clustering fields in the IT test
thus enable them to understand more about the concept.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #380 ☕️