Skip to content

feat: Make v1 the default protocolVersion #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelpri10 merged 1 commit into from
Dec 5, 2025
Merged

feat: Make v1 the default protocolVersion #2623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public class Subscriber extends AbstractApiService implements SubscriberInterfac
private final boolean maxDurationPerAckExtensionDefaultUsed;
private final java.time.Duration minDurationPerAckExtension;
private final boolean minDurationPerAckExtensionDefaultUsed;
private final long protocolVersion;
private final long protocolVersion = 1L;

// The ExecutorProvider used to generate executors for processing messages.
private final ExecutorProvider executorProvider;
Expand Down Expand Up @@ -183,7 +183,6 @@ private Subscriber(Builder builder) {
maxDurationPerAckExtensionDefaultUsed = builder.maxDurationPerAckExtensionDefaultUsed;
minDurationPerAckExtension = builder.minDurationPerAckExtension;
minDurationPerAckExtensionDefaultUsed = builder.minDurationPerAckExtensionDefaultUsed;
protocolVersion = builder.protocolVersion;

clock = builder.clock.isPresent() ? builder.clock.get() : CurrentMillisClock.getDefaultClock();

Expand Down Expand Up @@ -551,8 +550,6 @@ public static final class Builder {
private boolean enableOpenTelemetryTracing = false;
private OpenTelemetry openTelemetry = null;

private long protocolVersion = 0L;

private SubscriberShutdownSettings subscriberShutdownSettings =
SubscriberShutdownSettings.newBuilder().build();

Expand Down Expand Up @@ -776,12 +773,6 @@ Builder setClock(ApiClock clock) {
return this;
}

/** Gives the ability to override the protocol version */
public Builder setProtocolVersion(long protocolVersion) {
this.protocolVersion = protocolVersion;
return this;
}

/**
* OpenTelemetry will be enabled if setEnableOpenTelemetry is true and and instance of
* OpenTelemetry has been provied. Warning: traces are subject to change. The name and
Expand Down