Skip to content

feat: [Internal] open telemetry built in metrics for GRPC #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
surbhigarg92 merged 13 commits into from
Apr 17, 2025
Merged

feat: [Internal] open telemetry built in metrics for GRPC #3709

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5806943
feat: grpc metrics
surbhigarg92 Mar 25, 2025
4329770
test
surbhigarg92 Mar 25, 2025
1f87e91
grpc metrics env check
surbhigarg92 Mar 26, 2025
c18fec2
skip test and clirr
surbhigarg92 Mar 26, 2025
7b6c0a7
add grpc metrics in allowed metrics
surbhigarg92 Mar 26, 2025
01adb67
test: logs
surbhigarg92 Apr 2, 2025
70ff8bf
chore: generate libraries at Wed Apr 2 17:15:18 UTC 2025
cloud-java-bot Apr 2, 2025
80d3017
chore: generate libraries at Wed Apr 2 17:18:00 UTC 2025
cloud-java-bot Apr 2, 2025
b2f4293
remove logs
surbhigarg92 Apr 3, 2025
5b29243
review
surbhigarg92 Apr 3, 2025
64e02f7
clirr
surbhigarg92 Apr 3, 2025
1801433
review comments
surbhigarg92 Apr 16, 2025
94e8161
enable grpc metrics only env is set to false
surbhigarg92 Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review comments
  • Loading branch information
@surbhigarg92
surbhigarg92 committed Apr 16, 2025
commit 180143332044f7feddc7d07682e14496af378d36
4 changes: 2 additions & 2 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public class BuiltInMetricsConstant {
DIRECT_PATH_ENABLED_KEY,
DIRECT_PATH_USED_KEY);

public static final Set<String> GRPC_ATTRIBUTES =
static final Set<String> GRPC_LB_RLS_ATTRIBUTES =
ImmutableSet.of("grpc.lb.rls.data_plane_target", "grpc.lb.pick_result");

static Aggregation AGGREGATION_WITH_MILLIS_HISTOGRAM =
Expand Down Expand Up @@ -212,7 +212,7 @@ private static void defineGRPCView(ImmutableMap.Builder<InstrumentSelector, View
BuiltInMetricsConstant.COMMON_ATTRIBUTES.stream()
.map(AttributeKey::getKey)
.collect(Collectors.toSet());
attributesFilter.addAll(BuiltInMetricsConstant.GRPC_ATTRIBUTES);
attributesFilter.addAll(BuiltInMetricsConstant.GRPC_LB_RLS_ATTRIBUTES);

View view =
View.builder()
Expand Down
1 change: 1 addition & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ void enableGrpcMetrics(
GrpcOpenTelemetry.newBuilder()
.sdk(this.getOrCreateOpenTelemetry(projectId, credentials, monitoringHost))
.enableMetrics(BuiltInMetricsConstant.GRPC_METRICS_TO_ENABLE)
// Disable gRPCs default metrics as they are not needed for Spanner.
.disableMetrics(BuiltInMetricsConstant.GRPC_METRICS_ENABLED_BY_DEFAULT)
.build();
ApiFunction<ManagedChannelBuilder, ManagedChannelBuilder> channelConfigurator =
Expand Down
Loading