This repository was archived by the owner on Sep 16, 2023. It is now read-only.
Create system test case for text to speech API #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload system test case for text to speech API v1
Upload system test case for text to speech API v1beta1
Code Format
Code Format
chingor13
suggested changes
Oct 23, 2019
Contributor
chingor13
left a comment
There was a problem hiding this comment.
Can you move these tests into an it folder, change the package to include it and rename the files/classes to ITSystemTest?
We have common config across our projects that use this convention to limit which tests we run and when.
...loud-texttospeech/src/test/java/com/google/cloud/texttospeech/v1/TextToSpeechSystemTest.java
Outdated
Show resolved
Hide resolved
...texttospeech/src/test/java/com/google/cloud/texttospeech/v1beta1/TextToSpeechSystemTest.java
Outdated
Show resolved
Hide resolved
…cloud/texttospeech/v1/TextToSpeechSystemTest.java to google-cloud-texttospeech/src/test/java/com/google/cloud/texttospeech/v1/it/ITSystemTest.java ITSystemTest
…cloud/texttospeech/v1beta1/TextToSpeechSystemTest.java to google-cloud-texttospeech/src/test/java/com/google/cloud/texttospeech/v1beta1/it/ITSystemTest.java ITSystemTest
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
========================================
Coverage 66.2% 66.2%
Complexity 72 72
========================================
Files 12 12
Lines 432 432
Branches 2 2
========================================
Hits 286 286
Misses 144 144
Partials 2 2Continue to review full report at Codecov.
|
Contributor
|
Codecov can't possibly be correct about test coverage dropping - ignore that "failure". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload system test case for text to speech API(both v1 and v1beta1).