Skip to content

feat: convert BIGNUMERIC values to decimal objects #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 5 commits into from
Dec 4, 2020
Merged

feat: convert BIGNUMERIC values to decimal objects #414

gcf-merge-on-green merged 5 commits into from
Dec 4, 2020

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 3, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #367 🦕

@tswast tswast requested review from a team and stephaniewang526 December 3, 2020 20:15
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@tswast tswast requested review from shollyman and steffnay and removed request for stephaniewang526 December 3, 2020 20:15
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit d472d2d into master Dec 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2020
@tswast tswast deleted the tswast-patch-1-1 branch December 4, 2020 22:33
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @shollyman