Skip to content

Conversation

@zoercai
Copy link
Contributor

@zoercai zoercai commented Feb 4, 2021

This PR modifies existing samples and adds a sample to show how to use the PITR feature.

@zoercai zoercai requested review from a team as code owners February 4, 2021 05:52
@zoercai zoercai requested review from dinagraves and removed request for a team February 4, 2021 05:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Feb 4, 2021
@snippet-bot
Copy link

snippet-bot bot commented Feb 4, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@zoercai zoercai added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 4, 2021
@thiagotnunes thiagotnunes changed the title Add PITR samples feat: adds samples for PITR Feb 4, 2021
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagotnunes
Copy link
Contributor

This should only be merged after #148 is merged.

@larkee
Copy link
Contributor

larkee commented Feb 4, 2021

This should only be merged after #148 is merged.

This should be merged after a release that contains #148 to avoid breaking sample tests that run using the latest release.

@larkee larkee changed the title feat: adds samples for PITR feat: add samples for PITR Feb 5, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2021
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new samples to backup_sample.py. Python does not split individual samples into separate files like other languages.

@zoercai zoercai requested a review from larkee February 24, 2021 03:38
@zoercai zoercai requested a review from larkee February 24, 2021 06:46
@zoercai zoercai requested a review from larkee February 24, 2021 23:59
@zoercai zoercai requested a review from larkee February 25, 2021 00:58
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the line is reverted 👍

@zoercai zoercai added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit da146b7 into master Feb 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the pitr-samples branch February 25, 2021 01:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 8, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [3.2.0](https://www.github.com/googleapis/python-spanner/compare/v3.1.0...v3.2.0) (2021-03-02)


### Features

* add `Database.list_tables` method ([#219](https://www.github.com/googleapis/python-spanner/issues/219)) ([28bde8c](https://www.github.com/googleapis/python-spanner/commit/28bde8c18fd76b25ec1b64c44db7c1600255256f))
* add sample for commit stats ([#241](https://www.github.com/googleapis/python-spanner/issues/241)) ([1343656](https://www.github.com/googleapis/python-spanner/commit/1343656ad43dbc41c119b652d8fe9360fa2b0e78))
* add samples for PITR ([#222](https://www.github.com/googleapis/python-spanner/issues/222)) ([da146b7](https://www.github.com/googleapis/python-spanner/commit/da146b7a5d1d2ab6795c53301656d39e5594962f))


### Bug Fixes

* remove print statement ([#245](https://www.github.com/googleapis/python-spanner/issues/245)) ([1c2a64f](https://www.github.com/googleapis/python-spanner/commit/1c2a64fd06404bb7c2dfb4a8f65edd64c7710340))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants