Skip to content

[ggj][codegen] fix: generate param-less RPC Java methods for empty sigs #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 7 commits into from
Nov 26, 2020
Merged

[ggj][codegen] fix: generate param-less RPC Java methods for empty sigs #575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e9abbb
fix: handle empty method_signature in parsing protos
miraleung Nov 25, 2020
3e21503
fix: add google/type:type_java_proto as default test dep
miraleung Nov 25, 2020
bcecb1f
fix: support singleton resource names in parsing and codegen
miraleung Nov 26, 2020
d22c29f
fix: generate param-less RPC Java methods for empty sigs
miraleung Nov 26, 2020
599a54b
fix: merge master
miraleung Nov 26, 2020
dfd9566
Merge branch 'master' into dev/3
miraleung Nov 26, 2020
2db362d
fix: merge master
miraleung Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add google/type:type_java_proto as default test dep
  • Loading branch information
@miraleung
miraleung committed Nov 25, 2020
commit 3e21503a4ae5c1ef2059d34e4e30ed1b62978a88
1 change: 1 addition & 0 deletions rules_java_gapic/java_gapic.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def java_gapic_library(

# Test deps.
actual_test_deps = test_deps + actual_deps + [
"@com_google_googleapis//google/type:type_java_proto", # Commonly used.
"@com_google_api_gax_java//gax-grpc:gax_grpc_testlib",
"@com_google_api_gax_java//gax:gax_testlib",
"@com_google_code_gson_gson//jar",
Expand Down
2 changes: 0 additions & 2 deletions test/integration/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ java_gapic_library(
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
"@com_google_googleapis//google/iam/v1:iam_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_proto",
"@com_google_googleapis//google/type:type_java_proto",
],
)

Expand All @@ -75,7 +74,6 @@ java_gapic_assembly_gradle_pkg(
"@com_google_googleapis//google/cloud/asset/v1:asset_java_proto",
"@com_google_googleapis//google/cloud/asset/v1:asset_proto",
"@com_google_googleapis//google/cloud/orgpolicy/v1:orgpolicy_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/type:type_java_proto",
"@com_google_googleapis//google/identity/accesscontextmanager/v1:accesscontextmanager_java_proto",
],
)
Expand Down