Skip to content

fix: Update prometheus.exporter.postgresql to work properly with postgres 17 #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

dehaansa
Copy link
Contributor

@dehaansa dehaansa commented Mar 12, 2025

PR Description

Ports the work in the upstream prometheus-community/postgres_exporter#1072 exporter to the grafana fork used in Alloy to resolve stat_bgwriter collector issues, and add the stat_checkpointer collector.

Which issue(s) this PR fixes

Fixes #2388

Notes to the Reviewer

Tested locally against a postgres17 instance installed via homebrew.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@dehaansa dehaansa requested review from clayton-cornell and a team as code owners March 12, 2025 14:18
Copy link
Contributor

github-actions bot commented Mar 12, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for chasing this!

@dehaansa
Copy link
Contributor Author

@clayton-cornell any issues with adding the note about supported version for the new collector to the list?

image

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment for PostgreSQL as the full product name.

@clayton-cornell
Copy link
Contributor

any issues with adding the note about supported version for the new collector to the list?

I can't think of any reason not to add the info. It's important.

@dehaansa
Copy link
Contributor Author

dehaansa commented Mar 12, 2025

I was looking more for a style concern e.g. we should put it in an admonition.

Oh. I see what you mean.

If we drop it into an admonition where it is now, it won't "fit" properly in the column list.
We could place a note under the list, but that risks being missed by the readers.
For now, we can leave it as-is. The info is clear... not optimal, but good enough for now.

@dehaansa dehaansa enabled auto-merge (squash) March 12, 2025 20:22
@dehaansa dehaansa merged commit 3f52ee7 into main Mar 12, 2025
35 checks passed
@dehaansa dehaansa deleted the fix/postgres17 branch March 12, 2025 20:36
dehaansa added a commit that referenced this pull request Mar 13, 2025
…stgres 17 (#2972)

* Add support for postgres17 in prometheus.exporter.postgres

* Update changelog

* Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3f52ee7)
@dehaansa dehaansa mentioned this pull request Mar 13, 2025
dehaansa added a commit that referenced this pull request Mar 13, 2025
* remotecfg: Fix errNotModified causing incorrect last_load metric and printing invalid error logs (#2977)

Fixing behavior of errNotModified and remotecfg_last_load_successful metric. This also prevents invalid error log messages from being printed.

(cherry picked from commit 7350cac)

* Fix attribute name in Beyla configuration. (#2966)

(cherry picked from commit 5b5752a)

* fix: Update `prometheus.exporter.postgresql` to work properly with postgres 17 (#2972)

* Add support for postgres17 in prometheus.exporter.postgres

* Update changelog

* Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 3f52ee7)

* Update changelog

---------

Co-authored-by: Zachary Sistrunk <[email protected]>
Co-authored-by: Rafael Roquetto <[email protected]>
towolf pushed a commit to towolf/alloy that referenced this pull request Apr 2, 2025
…stgres 17 (grafana#2972)

* Add support for postgres17 in prometheus.exporter.postgres

* Update changelog

* Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
towolf pushed a commit to towolf/alloy that referenced this pull request Apr 2, 2025
…stgres 17 (grafana#2972)

* Add support for postgres17 in prometheus.exporter.postgres

* Update changelog

* Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running the postgres exporter with postgres 17
3 participants