-
Notifications
You must be signed in to change notification settings - Fork 378
fix: Update prometheus.exporter.postgresql
to work properly with postgres 17
#2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💻 Deploy preview deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for chasing this!
@clayton-cornell any issues with adding the note about supported version for the new collector to the list? ![]() |
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment for PostgreSQL as the full product name.
I can't think of any reason not to add the info. It's important. |
…er.postgres.md Co-authored-by: Clayton Cornell <[email protected]>
Oh. I see what you mean. If we drop it into an admonition where it is now, it won't "fit" properly in the column list. |
…stgres 17 (#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 3f52ee7)
* remotecfg: Fix errNotModified causing incorrect last_load metric and printing invalid error logs (#2977) Fixing behavior of errNotModified and remotecfg_last_load_successful metric. This also prevents invalid error log messages from being printed. (cherry picked from commit 7350cac) * Fix attribute name in Beyla configuration. (#2966) (cherry picked from commit 5b5752a) * fix: Update `prometheus.exporter.postgresql` to work properly with postgres 17 (#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 3f52ee7) * Update changelog --------- Co-authored-by: Zachary Sistrunk <[email protected]> Co-authored-by: Rafael Roquetto <[email protected]>
…stgres 17 (grafana#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]>
…stgres 17 (grafana#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]>
PR Description
Ports the work in the upstream prometheus-community/postgres_exporter#1072 exporter to the grafana fork used in Alloy to resolve
stat_bgwriter
collector issues, and add thestat_checkpointer
collector.Which issue(s) this PR fixes
Fixes #2388
Notes to the Reviewer
Tested locally against a postgres17 instance installed via homebrew.
PR Checklist