[misc] Improve distributed related env variables and setup #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolitaryThinker
approved these changes
Jun 8, 2025
Collaborator
There was a problem hiding this comment.
lets we just move this and related V1 preprocessing files (except those under scripts) to under fastvideo/v1?
| fastvideo_args = FastVideoArgs(model_path=args.model_path, | ||
| num_gpus=world_size, | ||
| device_str="cuda", | ||
| num_gpus=get_world_size(), |
Collaborator
There was a problem hiding this comment.
perhaps we should just remove num_gpus altogether, including in inference? If we always hardcode num_gpus=get_world_size() users would need to control it using CUDA_VISIBLE_DEVICES. When I added num_gpus I was only considering inference and also assumed tp_size == sp_size
Collaborator
There was a problem hiding this comment.
I think num_gpus is easier to control, if not specified we can use world size
Collaborator
|
Thanks! |
qimcis
pushed a commit
to qimcis/FastVideo
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.