[CI] Update Docker image to flash-attn 2.8.0 / CUDA 12.8 #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edenzzzz
reviewed
Jun 16, 2025
docker/Dockerfile.python3.12
Outdated
Comment on lines
44
to
45
| echo 'source /opt/venv/bin/activate' >> /root/.bashrc && \ | ||
| echo 'if [ -f ~/.bashrc ]; then . ~/.bashrc; fi' > /root/.profile |
Collaborator
There was a problem hiding this comment.
Can you add zsh and vim?
Collaborator
Author
There was a problem hiding this comment.
I can confirm that zsh and vim are working - the zsh configuration appears to be handled automatically, maybe by the uv installer, and zsh shells have access to the uv dependencies. I added login shell support as well
Collaborator
There was a problem hiding this comment.
ok thanks, let me try this on B200
SolitaryThinker
approved these changes
Jun 17, 2025
Collaborator
|
@kevin314 Looks like this PR causes CIs to fail |
qimcis
pushed a commit
to qimcis/FastVideo
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.