[Bugfix] Fix neg_prompt bug when training from local cp #708
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @BrianChen1129, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug related to the "negative_prompt" when training from local checkpoints. The fix involves providing a default string value for the "negative_prompt" in the "SamplingParam" configuration within "fastvideo/configs/sample/base.py", ensuring that a negative prompt is always present, even if not explicitly provided.
Highlights
- Bug Fix: Resolved an issue where the "negative_prompt" was not correctly handled when training from local checkpoints.
- Configuration Update: Updated the "negative_prompt" field in "fastvideo/configs/sample/base.py" to include a comprehensive default string value.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug related to the negative_prompt by providing a default value. The change is straightforward. My main feedback is to improve the code style by breaking up the very long string for the default negative prompt into multiple lines for better readability, in line with PEP 8 guidelines. This will also make the code more maintainable.
| # Text inputs | ||
| prompt: str | list[str] | None = None | ||
| negative_prompt: str | None = None | ||
| negative_prompt: str = "Bright tones, overexposed, static, blurred details, subtitles, style, works, paintings, images, static, overall gray, worst quality, low quality, JPEG compression residue, ugly, incomplete, extra fingers, poorly drawn hands, poorly drawn faces, deformed, disfigured, misshapen limbs, fused fingers, still picture, messy background, three legs, many people in the background, walking backwards" |
There was a problem hiding this comment.
This line is very long (over 300 characters) and exceeds common style guide recommendations (e.g., PEP 8), which makes the code harder to read. It's better to split this long string into multiple lines.1
For even better maintainability, you could define this default negative prompt as a module-level constant. This would also follow the Don't Repeat Yourself (DRY) principle, as this string is also used in other files like tests.
Style Guide References
| negative_prompt: str = "Bright tones, overexposed, static, blurred details, subtitles, style, works, paintings, images, static, overall gray, worst quality, low quality, JPEG compression residue, ugly, incomplete, extra fingers, poorly drawn hands, poorly drawn faces, deformed, disfigured, misshapen limbs, fused fingers, still picture, messy background, three legs, many people in the background, walking backwards" | |
| negative_prompt: str = ( | |
| "Bright tones, overexposed, static, blurred details, subtitles, style, " | |
| "works, paintings, images, static, overall gray, worst quality, " | |
| "low quality, JPEG compression residue, ugly, incomplete, extra fingers, " | |
| "poorly drawn hands, poorly drawn faces, deformed, disfigured, " | |
| "misshapen limbs, fused fingers, still picture, messy background, " | |
| "three legs, many people in the background, walking backwards" | |
| ) |
Footnotes
-
PEP 8 suggests limiting all lines to a maximum of 79 characters for code and 72 for docstrings/comments. While this is a soft limit, very long lines like this one (over 300 characters) harm readability. ↩
No description provided.