-
Notifications
You must be signed in to change notification settings - Fork 229
[misc] [docs] Various fixes for logging and docs #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SolitaryThinker
commented
Aug 24, 2025
- update icons and logos to use svg
- pin torchcodec to 0.5.0 (due to our torch version)
- Update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @SolitaryThinker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on maintenance and documentation improvements. It updates various image assets to use the more scalable SVG format, refines the logging system's warning messages for clarity, and includes comprehensive updates to the project's documentation, covering installation procedures, supported models, and development environment configurations.
Highlights
- SVG Asset Migration: Replaced PNG/JPG image assets with SVG format across the
README.md, documentation, Gradio frontend, andpyproject.tomlfor improved scalability and clarity. - Documentation Overhaul: Updated CUDA version requirements from 12.4 to 12.8 across installation guides and hardware requirements. Migrated Conda environment setup to Python 3.12 and introduced
uvas a recommended installation tool, including detailed instructions. Refined Docker image tags and RunPod setup instructions. Expanded the model support matrix with new FastWan and Wan2.2 models, adding a 'Does not apply' symbol for clarity. Removed thevideo_sparse_attention/demo.mddocumentation page. - Dependency Management: Pinned the
torchcodecdependency to version0.5.0inpyproject.tomlto ensure compatibility with the current PyTorch version. - Logging Clarity: Improved the warning messages in the logging utility to explicitly state default behaviors regarding local main process and main process logging.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a variety of improvements, primarily focusing on documentation and asset updates. Key changes include migrating logos and icons to SVG for better quality, pinning the torchcodec dependency for stability, and updating documentation across the board with newer CUDA/Python versions and improved installation instructions using uv. The logger warning messages have also been made more informative. The changes are well-aligned with the goal of improving docs and fixing miscellaneous issues. I have a couple of minor suggestions in the documentation to enhance clarity and completeness.