Skip to content

Add encode & decode operations to base62 helper #10038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add encode & decode operations to base62 helper #10038

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
405bcef
Add encode & decode operations to base62 helper
sgmiller Sep 24, 2020
91bcc09
Accidental add
sgmiller Sep 24, 2020
1bfc08c
Fix unit tests, add benchmark
sgmiller Sep 24, 2020
aaf37e6
15% faster
sgmiller Sep 24, 2020
38e90ed
Add some helpful math comments
sgmiller Sep 24, 2020
96e0bff
must go faster
sgmiller Sep 25, 2020
4d628da
update tests
sgmiller Sep 25, 2020
c6dd42b
fix comment
sgmiller Sep 25, 2020
59229fc
Merge remote-tracking branch 'origin/master' into base62-encode-decode
sgmiller Sep 25, 2020
f1a3c16
Make the test simpler
sgmiller Sep 25, 2020
acae2f6
Fix prefixed zero handling
sgmiller Sep 26, 2020
0091322
Squeeze a dozen more % perf
sgmiller Sep 26, 2020
02d3ce0
Simplify
sgmiller Sep 26, 2020
076126e
Switch to an impl equivalent to that from base64 from github.com/mr-t…
sgmiller Oct 1, 2020
3752757
Merge branch 'master' into base62-encode-decode
sgmiller Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@sgmiller
sgmiller committed Sep 25, 2020
commit c6dd42b347eb19c70a42d620bf09b8055caaa682
3 changes: 2 additions & 1 deletion sdk/helper/base62/base62.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ func Decode(dst []byte, src string) ([]byte, error) {
var num big.Int
var x big.Int

// n = c[0]*62^0 + c[1]*62^1 + c[2]*62^2 ...
// n = c[0]
// n = n * 62 + c[1] ...
for i, c := range src {
if i > 0 {
num.Mul(&num, csLenBig)
Expand Down