minor formatting #10530
Open
minor formatting #10530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitography
requested changes
May 2, 2022
| @@ -154,7 +154,7 @@ In addition, a `+` can be used to denote any number of characters bounded | |||
| within a single path segment (this appeared in Vault 1.1): | |||
|
|
|||
| ```ruby | |||
| # Permit reading the "teamb" path under any top-level path under secret/ | |||
| # Permit reading the "teamb" path under any top-level path under secret/. | |||
There was a problem hiding this comment.
I think this is more confusing, and would not merge it. "." in the context of a path means a reference to the folder itself, so I would read this (with the path listed below) as "secret/secret/+/teamb/" if the "." is there.
| @@ -154,7 +154,7 @@ In addition, a `+` can be used to denote any number of characters bounded | |||
| within a single path segment (this appeared in Vault 1.1): | |||
|
|
|||
| ```ruby | |||
| # Permit reading the "teamb" path under any top-level path under secret/ | |||
| # Permit reading the "teamb" path under any top-level path under secret/. | |||
There was a problem hiding this comment.
I think this is more confusing, and would not merge it. "." in the context of a path means a reference to the folder itself, so I would read this (with the path listed below) as "secret/secret/+/teamb/" if the "." is there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.