Add an option to configure the HTTP proxy to use with the AWS auth method #13479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod We are using Vault Enterprise with multiple namespaces in an environment where we have to use an HTTP proxy to access the AWS API. The configuration for the AWS auth method currently makes it possible to change the endpoints VAult will contact by setting `endpoint`, `iam_endpoint` and `sts_endpoint` but there is currently no way to set an HTTPS proxy. While we could set the `HTTPS_PROXY` environment variable on the server this has the drawback on impacting all the HTTP requests made by Vault, not just the ones made by this authentication method. This is an issue because we would like to use a proxy only for this auth method and not for the JWT one. We might also need to use another proxy for the Azure auth method and to use different proxies for different namespaces. This patch adds a new `http_proxy` parameter that can be used for this purpose. If not set the previous behavior on looking at the `HTTPS_PROXY` environment variable is kept so that it will continue to work for users already depending on it, however the environment variable will be overriden by this new parameter when it is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Vault Enterprise with multiple namespaces in an environment
where we have to use an HTTP proxy to access the AWS API. The
configuration for the AWS auth method currently makes it possible to
change the endpoints VAult will contact by setting
endpoint,iam_endpointand
sts_endpointbut there is currently no way to set an HTTPS proxy.While we could set the
HTTPS_PROXYenvironment variable on the serverthis has the drawback on impacting all the HTTP requests made by Vault,
not just the ones made by this authentication method. This is an issue
because we would like to use a proxy only for this auth method and not
for the JWT one. We might also need to use another proxy for the Azure
auth method and to use different proxies for different namespaces.
This patch adds a new
http_proxyparameter that can be used for thispurpose. If not set the previous behavior on looking at the
HTTPS_PROXYenvironment variable is kept so that it will continue to work for users
already depending on it, however the environment variable will be
overriden by this new parameter when it is set.