tf/aws: add download-version tf var #8599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
reviewed
Mar 20, 2020
| curl -L "${download_url}" > /tmp/vault.zip | ||
| vault_download_url=https://releases.hashicorp.com/vault/${download_version}/vault_${download_version}_linux_amd64.zip | ||
|
|
||
| if [[ ! -z "${download_url}" ]]; then |
There was a problem hiding this comment.
I find positive conditions easier to read than negative ones. I might suggest changing the ! -z to -n, as I believe they are equivalent. I don't think the double brackets are required here either. I think single brackets would suffice.
raskchanky
reviewed
Mar 20, 2020
| @@ -6,7 +6,13 @@ sudo apt-get update -y | |||
| sudo apt-get install -y curl unzip | |||
|
|
|||
| # Download Vault into some temporary directory | |||
| curl -L "${download_url}" > /tmp/vault.zip | |||
| vault_download_url=https://releases.hashicorp.com/vault/${download_version}/vault_${download_version}_linux_amd64.zip | |||
There was a problem hiding this comment.
It's probably worth wrapping this URL in double quotes, since there are variables in it. See https://github.com/koalaman/shellcheck/wiki/SC2086 for more details.
raskchanky
reviewed
Mar 20, 2020
| vault_download_url=https://releases.hashicorp.com/vault/${download_version}/vault_${download_version}_linux_amd64.zip | ||
|
|
||
| if [[ ! -z "${download_url}" ]]; then | ||
| vault_download_url=${download_url} |
There was a problem hiding this comment.
Same comment here as above re: double quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to add a
download-versionTF variable while still acceptingdownload-urlif that's provided.