CI - go mod test #9087
Open
CI - go mod test #9087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarahethompson there are failing tests on this branch, and on master, however they are not the same tests. I stil don't think your changes would have caused them, but I just pulled the latest from master into this branch to check we now get the same failing tests, assuming we do then it's ok to merge, thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of Jeff's changes in - #9000
to allow us to lock build-time dependencies to specific versions in CI as well (https://hashicorp.atlassian.net/browse/VLTES-102).
We will hopefully be able to move to Artifactory for our GOPROXY soon in CI once the Artifactory server is upgraded to fix - https://www.jfrog.com/jira/browse/RTFACT-19395.