Skip to content

Hlint plugin using ghc-lib #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jneira merged 71 commits into from
Oct 29, 2020
Merged

Hlint plugin using ghc-lib #166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
1ce5316
WIP on integrating hlint using DAML approach
alanz Feb 10, 2020
beb2e25
hlint plugin version with only diagnostics
jneira Jun 18, 2020
70ce253
Add apply-refact dependency
jneira Jun 21, 2020
a49ad1a
WIP adding apply hlint hints
jneira Jun 21, 2020
91af64b
Add missing dependencies
jneira Jul 1, 2020
6334ed5
Add hlint private lib
jneira Jul 1, 2020
6b06854
Update stack extra-deps
jneira Jul 1, 2020
cd8be02
Implement hlint applyOneCmd
jneira Jul 1, 2020
bd2a772
Move hlint module to its own src dir
jneira Jul 2, 2020
787a474
Rename lib to hlint-plugin
jneira Jul 2, 2020
4fbabd7
Move hlint plugin to a more generic path
jneira Jul 3, 2020
c03c385
Parse module with ghc session extensions
jneira Jul 7, 2020
1e3350c
Use both ghc and ghc-lib
jneira Jul 7, 2020
765d857
Make compile ghc-8.10.1 code path
jneira Jul 9, 2020
d3c6ee5
Remove unused imports and refact cpp blocks
jneira Jul 14, 2020
5c6885e
Remove trailing whitespace
jneira Jul 15, 2020
fd6fc80
Use ghcide with config in shakeExtras
jneira Aug 9, 2020
6e9a7bc
Add action to get client settings
jneira Aug 16, 2020
752c838
Make hlint depend on client setting
jneira Aug 16, 2020
0aef003
Use getFileContents action rule
jneira Aug 25, 2020
d13184e
Remove commented code from hie
jneira Aug 27, 2020
adeb930
Use edited content for compute edits
jneira Aug 28, 2020
26740f1
Use persisted VFS file with apply refact, expose applyAll
lukel97 Aug 29, 2020
7674fe7
Enable hlint tests
jneira Aug 29, 2020
ff778b6
Move test data to fix the cradle loading
jneira Aug 30, 2020
0e71e87
Fix hlint tests
jneira Aug 30, 2020
36982a5
Add indefinite progress to apply refact
jneira Sep 2, 2020
11086d5
Bump ghcide submodule
jneira Sep 7, 2020
b44ecb4
Adapt code to handle hashed value
jneira Sep 7, 2020
523953c
Replace vfs with raw temp file
jneira Sep 2, 2020
3a46078
Convert hlint-hls-plugin in a package
jneira Sep 9, 2020
a99912f
Rename to hls-hlint-plugin
jneira Sep 15, 2020
105c37f
Adapt to ghcide api changes
jneira Sep 16, 2020
706dfcc
Fix and clean stack extra-deps
jneira Oct 7, 2020
bff0d24
Use lsp-test-0.11.0.6
jneira Oct 17, 2020
55dfc3b
Fix hlint tests
jneira Oct 18, 2020
e24ebd2
Use hint name for code action title
jneira Oct 19, 2020
2f31ffb
Remove unused test data file
jneira Oct 19, 2020
839e75c
Remove unused parameter
jneira Oct 19, 2020
bf5108b
Add forcily needed hie.yaml
jneira Oct 19, 2020
7759c08
Make test not sensitive to commands order
jneira Oct 19, 2020
cd0b615
Make test resilient to default diags
jneira Oct 19, 2020
3adb995
Test only if the command has been applied
jneira Oct 19, 2020
f8dc9e0
Wait for hlint diagnostics explicitly
jneira Oct 19, 2020
3f4e950
Bump up ghc-lib min version
jneira Oct 19, 2020
89c4851
Use latest ghc-lib version
jneira Oct 19, 2020
8603c5c
Change mixins for PackageImport
jneira Oct 21, 2020
02308cd
Remove ghcide alternate repo
jneira Oct 22, 2020
e456f66
Simplify imports from ghcide
jneira Oct 25, 2020
814ad46
Use GHC.Compat from ghcide
jneira Oct 25, 2020
95dde7c
Restore imports for missing defs
jneira Oct 25, 2020
fc4ea30
Comment about the need to use tmp file
jneira Oct 25, 2020
73f669d
Remove hlintOn logging
jneira Oct 25, 2020
21b47f2
Remove hlint parser error from diagnostics
jneira Oct 25, 2020
d558e9a
Comment about GetHlintDiagnostics RuleResult
jneira Oct 26, 2020
1245439
Comment how hlint diags are recomputed
jneira Oct 26, 2020
e26b23f
Correct identation
jneira Oct 26, 2020
7f5a4ef
Use diagnostic code prefix "refact:"
jneira Oct 26, 2020
eeb62e0
Return hlint diags if no ghc parse errors
jneira Oct 26, 2020
929aaea
Combine hlint and hscEnv extensions
jneira Oct 26, 2020
f5d4311
Correct replace params
jneira Oct 26, 2020
1c1f7f3
Correct component name
jneira Oct 26, 2020
8b8e568
Fix apply refactoring
jneira Oct 26, 2020
c35cdda
Update tests to match new diags and ca's
jneira Oct 26, 2020
0e72151
Add GHC810 explicit version
jneira Oct 26, 2020
5d4d2e2
Set hlint code by ghc version
jneira Oct 26, 2020
f1751b7
Use hlint-3.2
jneira Oct 27, 2020
b549506
Remove ghc specific diag title
jneira Oct 27, 2020
ff0e4c7
Add and update comments
jneira Oct 27, 2020
01f8fd8
Provide evidence edits changes hlint diags
jneira Oct 27, 2020
94b7a3e
Rerun test suite to avoid flaky tests
jneira Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename lib to hlint-plugin
  • Loading branch information
@jneira
jneira committed Oct 28, 2020
commit 787a474e428214bbdc9ed0ea87c3a618b28bc8bc
4 changes: 2 additions & 2 deletions haskell-language-server.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ flag ghc-lib
manual: True
description: Force dependency on ghc-lib-parser even if GHC API in the ghc package is supported

library hls-ghc-lib
library hlint-plugin
Copy link
Member Author

@jneira jneira Jul 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted above the private lib does not work for stack based cradle.
Moreover i have to periodically delete the haskell-language-server library from the cabal store due to

exe\Main.hs:147:9: error:
    • Couldn't match expected type ‘Ide.Types.PluginDescriptor’
                  with actual type ‘haskell-language-server-0.2.0.0:Ide.Types.PluginDescriptor’
      NB: ‘haskell-language-server-0.2.0.0:Ide.Types.PluginDescriptor’
            is defined in ‘Ide.Types’
                in package ‘haskell-language-server-0.2.0.0’
          ‘Ide.Types.PluginDescriptor’
            is defined in ‘Ide.Types’
                in package ‘haskell-language-server-0.2.0.0’
    • In the expression: Hlint.descriptor "hlint"
      In the expression:
        [GhcIde.descriptor "ghcide", Pragmas.descriptor "pragmas",
         Floskell.descriptor "floskell", Ormolu.descriptor "ormolu", ....]
      In an equation for ‘basePlugins’:
          basePlugins
            = [GhcIde.descriptor "ghcide", Pragmas.descriptor "pragmas",
               Floskell.descriptor "floskell", ....]
    |
147 |       , Hlint.descriptor "hlint"
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

So i think this plugin must be separated in its own package, after the restructuration of the lib (see #164)

exposed-modules:
Ide.Plugin.Hlint
hs-source-dirs:
src
hlint-plugin/src
build-depends:
base
, aeson
Expand Down
6 changes: 3 additions & 3 deletions hie.yaml.cbl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ cradle:
- path: "./src"
component: "lib:haskell-language-server"

- path: "./src/Ide/Plugin/Hlint.hs"
component: "lib:hls-ghc-lib"
- path: "./hlint-plugin/src/Ide/Plugin/Hlint.hs"
component: "lib:hlint-plugin"

- path: "./.stack-work/"
- path: "./dist-newstyle/"
component: "lib:haskell-language-server"

- path: "./ghcide/src"
Expand Down