Skip to content

Support locales with names ending in ".UTF-8" - fixes #28 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bshannon
Copy link
Contributor

@bshannon bshannon commented Jun 6, 2018

No description provided.

@jkbzh
Copy link
Contributor

jkbzh commented Jun 7, 2018

@bshannon , this patch looks ok.

I'm wondering if it wouldn't be better to provide a configuration option to define the character set / encoding identifier, with a default of NULL. If it is set, then just concatenate that value before the call to setlocale, rather than always assuming a given locale only exists without this parameters or only in UTF-8.

@bshannon
Copy link
Contributor Author

bshannon commented Jun 7, 2018

Most everything is moving to UTF-8 these days, but having an ability to override that
seems like a reasonable enhancement request for someone to implement. I suspect
that the locale names without the .UTF-8 suffix are using some non-UTF-8 charset.
If such a locale exists, it will be used first. That plus the UTF-8 support probably covers
nearly all the interesting cases.

@jkbzh
Copy link
Contributor

jkbzh commented Oct 12, 2018

Thanks for your PR. I'm closing it without merging due to reasons described in #28

@jkbzh jkbzh closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants