Fix ISO-2022-JP support - fixes #36 #48
Conversation
…ing, from now translateurl() escapes URI strings only.
… call to make url escaping more consistent
…us-ascii but message headers include other encoded text like utf-8
at W3C by Fumi, Daigo, and myself. See Changelog for details
Correct includes for new glibc
|
@bshannon, do you think it could be possible to split this PR into two, one that deals with the changes you did for spamify (you can include the spamifiy_replacedomain changes in this eet) and another one for the rest of the iso-2022-jp changes? It will make it easier to test each set separately. It will also make it easier to review if I need to ask our i18n specialist colleagues something specific. |
|
Sorry, it's been way too long since I made these changes and I don't remember all the details, |
|
On Thu, Jun 07, 2018 at 01:58:32PM -0700, Bill Shannon wrote:
Sorry, it's been way too long since I made these changes and I don't remember all the details,
but as I remember it the spamify changes were part of making it work for iso-2022-jp because
spamify was making assumptions about how characters were encoded that just weren't valid
for iso-2022-jp.
@bshannon,
OK, fair enough for my having taken so long time to take care of your
of your code contribution. I'm grateful you still take time and in good
mood for helping so late on.
It's going to take me more time to finish analyzing this change. Ideally,
it's better to limit a MR to a specific contribution. C'est la vie.
I'll end splitting your changes in two so that I can test each part
separately.
By the way, I've been adding all your changes to hypermail/Changelog.
Please tell me if you'd prefer if you'd like me to add something
more to identify you, like an email address or @github_alias.
…--josé
|
|
Attributing these changes to "Bill Shannon" is fine. |
| /* correct the pointer and free the old */ | ||
| free(input); | ||
| return newbuf; | ||
| return replacechar(input, '@', set_antispam_at); |
There was a problem hiding this comment.
missing free(input) before the return
| else | ||
| PushByte(&buff, *input); | ||
| } | ||
|
|
|
Yes, you're probably right. (Too much time working in Java.) |
|
@bshannon, no it's ok. I'm going thru them. |
|
Hi @bshannon, Thank you for your contributions! I will close this PR when I merge that dev branch into master. |
Is the body not being handled in parseemail, like my comment says? |
I didn't look into detail for the reasons but spamify_replacedomain wasn't being applied to body when I enabled that change in struct.h. Disabling the changet made it work again. |
9ef9fbe to
1f4f886
Compare
|
hello |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This PR was already merged. |
No description provided.