"DOS line endings trip up charset #95" #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break off extraction of charset value after either newline or return, so we can coexist cleanly w. the DOS/Windows world. (Mostly the code doesn't care that a stray line ending slips in, but then there's the principle of least astonishment...)
|
Thanks for your report and patch. I manually added the code changes you proposed to the 3.0 branch. Further tests revealed this was not enough and that the same care was needed for all the other headers. This is now fixed. Thanks for bringing this up. |
Brunojoes69
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break off extraction of charset value after either newline or return, so we can coexist cleanly w. the DOS/Windows world.
(Mostly the code doesn't care that a stray line ending slips in, but then there's the principle of least astonishment...)