Skip to content

Yocto Project Linux platform detection support #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattray wants to merge 1 commit into from
Closed

Yocto Project Linux platform detection support #553

mattray wants to merge 1 commit into from

Conversation

@mattray
Copy link
Contributor

@mattray mattray commented Jan 15, 2020

Signed-off-by: Matt Ray [email protected]

Add support for Yocto Project Linux

Description

This is an embedded Linux that doesn't appear to use the LSB stuff by default.

@mattray mattray requested a review from a team as a code owner January 15, 2020 22:49
@ghost ghost requested review from clintoncwolfe and zenspider January 15, 2020 22:49
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Jan 15, 2020

Hello mattray! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

zenspider
zenspider approved these changes Jan 15, 2020
View reviewed changes
lib/train/platforms/detect/specifications/os.rb
plat.family("bsd").in_family("unix")
.detect do
# we need a better way to determin this family
# we need a better way to determine this family
Copy link
Contributor

@zenspider zenspider Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! thank you

@clintoncwolfe
Copy link
Contributor

clintoncwolfe commented Jan 16, 2020

Thanks for this! I suspect you need to rebase against master to pickup #554 to get your tests to turn green.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 16, 2020

Code Climate has analyzed commit a06dfb6 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 6

View more on Code Climate.

@mattray
Copy link
Contributor Author

mattray commented Jan 16, 2020 •
edited
Loading

@clintoncwolfe I rebased but it appears that there are failures in the wrlinux tests? Digging into this to see why they're being triggered by this patch.

@mattray
Copy link
Contributor Author

mattray commented Jan 17, 2020

Removing this PR to add full-fledged Yocto family support to handle Yocto and BaleenaOS

@mattray mattray closed this Jan 17, 2020
@mattray mattray deleted the yocto branch January 17, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

+1 more reviewer

@zenspider zenspider zenspider approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattray @clintoncwolfe @zenspider