Skip to content

Rebase #339 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zenspider merged 3 commits into from
Feb 3, 2020
Merged

Rebase #339 #566

zenspider merged 3 commits into from
Feb 3, 2020

Conversation

@zenspider
Copy link
Contributor

@zenspider zenspider commented Jan 31, 2020

This rebases and rewrites #339 against current master. Mostly just style / testing issues were in conflict.

@mgrobelin @zenspider
Replace usage of Ruby's stdlib URI by Addressable::URI
3e04650 
"Addressable is a replacement for the URI implementation that is part of Ruby's standard library. It more closely conforms to RFC 3986, RFC 3987, and RFC 6570 (level 4), additionally providing support for IRIs and URI templates.", see https://github.com/sporkmonger/addressable

Fixes #110

Signed-off-by: Markus Grobelin <[email protected]>
@mgrobelin @zenspider
Added addressable gem for better URI handling
45452e0 
Signed-off-by: Markus Grobelin <[email protected]>
@mgrobelin @zenspider
fixed linting and removed addressable from Gemfile
e1aa37b 
see #339 (review)

Signed-off-by: Markus Grobelin <[email protected]>
@zenspider zenspider requested a review from a team as a code owner January 31, 2020 23:59
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Jan 31, 2020

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider zenspider mentioned this pull request Jan 31, 2020
Closed
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 31, 2020

Code Climate has analyzed commit e1aa37b and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Style 3

View more on Code Climate.

miah
miah approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

@zenspider
Copy link
Contributor Author

zenspider commented Feb 1, 2020

Since #339 was basically signed off on w/ a couple caveats, which are addressed here, then I think this is good to go.

@miah miah requested a review from a team February 1, 2020 00:06
@zenspider zenspider merged commit 77fa475 into master Feb 3, 2020
@chef-expeditor chef-expeditor bot deleted the zenspider/rebase/addressable_gem_instead_of_stdlib_uri branch February 3, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintoncwolfe clintoncwolfe Awaiting requested review from clintoncwolfe

1 more reviewer

@miah miah miah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zenspider zenspider

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zenspider @miah @mgrobelin