Skip to content

feat(modal): add expandToScroll property to allow scrolling at all breakpoints #30097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Feb 3, 2025
Merged

feat(modal): add expandToScroll property to allow scrolling at all breakpoints #30097

Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
ea68986
feat(modal): added snapBreakpoints to sheet modals
kumibrr Dec 22, 2024
4970471
fix: removed trailing semicolon
kumibrr Dec 22, 2024
95c5314
chore: ran build
kumibrr Dec 26, 2024
1dcf5c9
refactor(modal): replaced snapBreakpoints array implementation with s…
kumibrr Jan 14, 2025
96c5e41
feat(modal): add contentAnimation support and animateContentHeight op…
kumibrr Jan 14, 2025
4d0d56f
Merge branch 'ionic-team:main' into main
kumibrr Jan 14, 2025
37c5832
feat(modal): added footer animation.
kumibrr Jan 27, 2025
566d3db
feat(modal): improved implementation
kumibrr Jan 27, 2025
9ab3733
fix: added back breakpoint: 0
kumibrr Jan 27, 2025
556cb6a
removed console.log
kumibrr Jan 28, 2025
ad90cd9
feat: added footer slide-in and slide-out animation
kumibrr Jan 28, 2025
396bf73
fix: footerAnimation did not exist at gestures initialization.
kumibrr Jan 28, 2025
ac11277
restored footer onMove and onEnd animations
kumibrr Jan 28, 2025
44b8152
refactor(modal): use a clone footer to prevent flickering
thetaPC Jan 29, 2025
804d043
fix(modal): add animation when scrollAtEdge is false
thetaPC Jan 29, 2025
59dd5b0
Merge pull request #1 from thetaPC/scroll
kumibrr Jan 29, 2025
4052a86
feat(modal): implement footer visibility swap for scrollAtEdge handling
kumibrr Jan 29, 2025
f4cf4c1
chore: added comments explaining footer visibility swaps
kumibrr Jan 29, 2025
df96686
feat(modal): added footer visibility swap based on scrollAtEdge in le…
kumibrr Jan 29, 2025
991e02a
fix(modal): padding value was always zero
kumibrr Jan 29, 2025
7c24b1f
chore(modal): minor fixes
kumibrr Jan 29, 2025
6d3473f
Merge remote-tracking branch 'upstream/main'
thetaPC Jan 29, 2025
6778e42
feat(modal): add padding to the first toolbar in modal sheets
kumibrr Jan 29, 2025
cef6fd7
fix(modal): limited padding-top to only apply on ios styles
kumibrr Jan 29, 2025
c8392bb
chore(modal): added explanation for padding-top
kumibrr Jan 29, 2025
dc4caaf
chore(modal): added section for sheet modal
kumibrr Jan 29, 2025
f6702a7
chore(vue): remove file
thetaPC Jan 29, 2025
b1726ec
Merge branch 'main' of github.com:kumibrr/ionic-framework
thetaPC Jan 29, 2025
42aa703
fix(modal): add missing parameter
thetaPC Jan 30, 2025
30e2d8b
test(modal): update snapshots
thetaPC Jan 30, 2025
3a79743
refactor(modal): add comments
thetaPC Jan 30, 2025
aca5855
Merge branch 'feature-8.5' into main
brandyscarney Jan 30, 2025
6e07a6f
refactor(modal): add requested changes
thetaPC Jan 31, 2025
80a826e
Merge branch 'main' of github.com:kumibrr/ionic-framework
thetaPC Jan 31, 2025
df2c331
chore(vue): run build
thetaPC Jan 31, 2025
e15ae91
fix(vue): add missing new line
thetaPC Jan 31, 2025
4ffa5f6
fix(modal): add footer check
thetaPC Jan 31, 2025
bbbdb87
chore(core): run build
thetaPC Jan 31, 2025
433f563
Update core/src/components/modal/animations/md.leave.ts
thetaPC Feb 1, 2025
a9ea2f4
Update core/src/components/modal/animations/ios.leave.ts
thetaPC Feb 1, 2025
c099027
Update core/src/components/modal/gestures/sheet.ts
thetaPC Feb 1, 2025
ce909b0
Update core/src/components/modal/gestures/sheet.ts
thetaPC Feb 1, 2025
c0d75b5
Update core/src/components/modal/gestures/sheet.ts
thetaPC Feb 1, 2025
6416ebe
Update core/src/components/modal/gestures/sheet.ts
thetaPC Feb 1, 2025
f6cc539
Update core/src/components/modal/gestures/sheet.ts
thetaPC Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(vue): add missing new line
  • Loading branch information
@thetaPC
thetaPC committed Jan 31, 2025
commit e15ae91680d3a19065a293b9071f4277601210fd
2 changes: 1 addition & 1 deletion packages/vue/src/components/Overlays.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended by the Stencil team to delete this file in order to get the build to pass.

Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ export const IonPickerLegacy = /*@__PURE__*/ defineOverlayContainer<JSX.IonPicke
export const IonPopover = /*@__PURE__*/ defineOverlayContainer<JSX.IonPopover>('ion-popover', defineIonPopoverCustomElement, ['alignment', 'animated', 'arrow', 'backdropDismiss', 'component', 'componentProps', 'dismissOnSelect', 'enterAnimation', 'event', 'focusTrap', 'htmlAttributes', 'isOpen', 'keepContentsMounted', 'keyboardClose', 'leaveAnimation', 'mode', 'reference', 'showBackdrop', 'side', 'size', 'translucent', 'trigger', 'triggerAction']);

export const IonToast = /*@__PURE__*/ defineOverlayContainer<JSX.IonToast>('ion-toast', defineIonToastCustomElement, ['animated', 'buttons', 'color', 'cssClass', 'duration', 'enterAnimation', 'header', 'htmlAttributes', 'icon', 'isOpen', 'keyboardClose', 'layout', 'leaveAnimation', 'message', 'mode', 'position', 'positionAnchor', 'swipeGesture', 'translucent', 'trigger']);


Loading