-
-
Notifications
You must be signed in to change notification settings - Fork 36
Sync with upstream @ e074a5f8 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
Fixing a typo
minor type fixes
minor typo fix
There are some missing "=" sign according to the question.
The title makes me ask "is 'if' keyword operator or not?". I think 'if' is not operator because it does not return any value and it is called if-statement.
Used "unitialized" instead of "uninitialized"
There are also array literals and string literals.
Minor edit around example code: " should be around id
Move comma before square bracket Object.create(proto[, descriptors])
Revision to unary plus not allowed bigints description in response to PR
Fix javascript-tutorial#2090 - Spelling Mistake Close javascript-tutorial#2079 - Remove 'elem' from `elem.scrollLeft/scrollTop`
Some Corrections
Fix javascript-tutorial#2098 - replace let with var in IIFE example
Improve 'long polling' article. Complements #2073.
Corrected spelling of "representation"
Update article.md
Sync safe Number borders across chapter 1.2.5
Update article.md
Fix typo in 1.2.6
Update article.md
Fix link in 1.2.8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at e074a5f
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
This PR will be closed and replaced with a new one in a few days.