-
-
Notifications
You must be signed in to change notification settings - Fork 36
Sync with upstream @ dccca58f #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Muhammed Zakir <[email protected]>
Adding the missin closing bracket.
Fix #2068 - Army of Functions Fix #2070 - Typo Fix #2056 - Grammatical Error Fix #2074 - Remove semi-colon after function declaration
Somewhat enhanced readability
add missing closing bracket
Update article.md
fix typo and minor grammatical error
…stion suggestion to use alert method not console.log
The last 2 code snippets shouldn't be runnable
misplaced "too"?
Update article.md
Confucius never said black cat quote
Delete a blank
One line of code creates a lot of confusing
Maybe it is "Object.defineProperty()" rather than "defineProperty()"
It seems there are no polymorphic functions in this chapter.
Fix possibly outdated note in 1.9.6 (instanceof)
Include "object" in MDN link
Update task.md
Minor clarification on WeakMap and WeakSet
Replace rules.indent array with number
Update topic sentence
Fix links in 1.8.4 (Prototype methods)
Add emphasis for clarity
Update article.md
Delete excess semicolon in 1.9.1 (Class basic syntax)
Clarify task code place in 1.9.1 (Class basic syntax)
Add missing semicolons in 1.9.2 (Class inheritance)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at dccca58
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
Please ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.