ninja code #37
ninja code #37
Conversation
This MR will sync up your branch with latest master.
There was a problem hiding this comment.
Thanks for the MR @ayushhagarwal. I can see a lot of potential improvements. You can use the preview tab on the Github ci or just go through the translated article on your favourite IDE and make any required improvements. Let me know if you have already done the initial review. I can run through it post that.
|
|
||
|
|
||
| ```quote author="Confucius (Analects)" | ||
| Learning without thought is labor lost; thought without learning is perilous. | ||
| ```उद्धरण लेखक = "कन्फ्यूशियस (अनालेक्ट्स)" |
There was a problem hiding this comment.
These are smart tags, used by the page generator to generate the doc site. The site generator will fail if we change them.
There was a problem hiding this comment.
Thanks for the PR @ayushhagarwal. I can see a lot of potential improvements. You can use the preview tab on the Github ci or just go through the translated article on your favourite IDE and make any required improvements. Let me know if you have already done the initial review. I can run through it post that.
|
Please make the requested changes. After it, add a comment "/done". |
|
I have made changes to t he quote and also made my final review. You can go for your review and then suggest if any more improvements required. |
|
Sorry, @ayushhagarwal I missed your comment completely. You will have to click on the request review once, so one of the reviewers gets notified. I will review this Sunday evening. Thanks anyway |
Creating pull request for translation of ninja code section. Will review it once again myself and other other reviews and comments are welcomed.